Include child in failed validation path when disallowed additional properties are found #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it fails validating a child, the error path should be for the child key, not the root.
carolynvs
changed the title
|
@carolynvs Thanks for the PR will take a look in the next day or two. It's definitely within the scope for JSONSchema and sorry if I wasn't clear enough on the issue. 2019 spec doesn't really give a specific requirement 2020 does. Which leaves the 2019 spec up to us to figure out and I think the ergonomy here is well worth it. |
Arqu
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it fails validating a child, the error path should be for the child key, not the root.
@Arqu had said that perhaps this fix should target the 2020 spec, but I wasn't sure where that change should be made? Happy to move the fix elsewhere if someone can point me in the right direction.
Fixes #91